Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f78f18c3 authored by Martin Wilck's avatar Martin Wilck Committed by Greg Kroah-Hartman
Browse files

scsi: qla2xxx: fix rports not being mark as lost in sync fabric scan 

commit d341e9a8f2cffe4000c610225c629f62c7489c74 upstream.

In qla2x00_find_all_fabric_devs(), fcport->flags & FCF_LOGIN_NEEDED is a
necessary condition for logging into new rports, but not for dropping lost
ones.

Fixes: 726b8548 ("qla2xxx: Add framework for async fabric discovery")
Link: https://lore.kernel.org/r/20191122221912.20100-2-martin.wilck@suse.com


Tested-by: default avatarDavid Bond <dbond@suse.com>
Signed-off-by: default avatarMartin Wilck <mwilck@suse.com>
Acked-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 216e517c

drivers/scsi/qla2xxx/qla_init.c

+3 −3
Original line number Diff line number Diff line
@@ -5710,8 +5710,7 @@ qla2x00_find_all_fabric_devs(scsi_qla_host_t *vha) 
		if (test_bit(LOOP_RESYNC_NEEDED, &vha->dpc_flags))

			break;



		if ((fcport->flags & FCF_FABRIC_DEVICE) == 0 ||

		    (fcport->flags & FCF_LOGIN_NEEDED) == 0)

		if ((fcport->flags & FCF_FABRIC_DEVICE) == 0)

			continue;



		if (fcport->scan_state == QLA_FCPORT_SCAN) {
@@ -5734,7 +5733,8 @@ qla2x00_find_all_fabric_devs(scsi_qla_host_t *vha) 
			}

		}



		if (fcport->scan_state == QLA_FCPORT_FOUND)

		if (fcport->scan_state == QLA_FCPORT_FOUND &&

		    (fcport->flags & FCF_LOGIN_NEEDED) != 0)

			qla24xx_fcport_handle_login(vha, fcport);

	}

	return (rval);