Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f74a834a authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFSv4.x: CB_SEQUENCE should return NFS4ERR_DELAY if still executing



See RFC5661 Section 2.10.6.2: if retrying a request, and the old one is
still in progress, we must return NFS4ERR_DELAY as the reply to sequence.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent f4f58ed1
Loading
Loading
Loading
Loading
+2 −0
Original line number Diff line number Diff line
@@ -375,6 +375,8 @@ validate_seqid(struct nfs4_slot_table *tbl, struct cb_sequenceargs * args)
	if (args->csa_sequenceid == slot->seq_nr) {
		dprintk("%s seqid %u is a replay\n",
			__func__, args->csa_sequenceid);
		if (tbl->highest_used_slotid != NFS4_NO_SLOT)
			return htonl(NFS4ERR_DELAY);
		/* Signal process_op to set this error on next op */
		if (args->csa_cachethis == 0)
			return htonl(NFS4ERR_RETRY_UNCACHED_REP);