Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f73b75f7 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Greg Kroah-Hartman
Browse files

i2c: emev2: add IRQ check 



[ Upstream commit bb6129c32867baa7988f7fd2066cf18ed662d240 ]

The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_irq() (which
takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
an original error code.  Stop calling devm_request_irq() with invalid
IRQ #s.

Fixes: 5faf6e1f ("i2c: emev2: add driver")
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 92a5d9ce

drivers/i2c/busses/i2c-emev2.c

+4 −1
Original line number Diff line number Diff line
@@ -397,7 +397,10 @@ static int em_i2c_probe(struct platform_device *pdev) 


	em_i2c_reset(&priv->adap);



	priv->irq = platform_get_irq(pdev, 0);

	ret = platform_get_irq(pdev, 0);

	if (ret < 0)

		goto err_clk;

	priv->irq = ret;

	ret = devm_request_irq(&pdev->dev, priv->irq, em_i2c_irq_handler, 0,

				"em_i2c", priv);

	if (ret)