Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7233c54 authored by Anjali Singhai Jain's avatar Anjali Singhai Jain Committed by Jeff Kirsher
Browse files

i40e: Some FD message fixes 



Change the message that gets printed when adding/deleting a filter to
the SB, so that user can tell if a filter was added or deleted.
Print filter add failures only in case of SB filters. For ATR the
information is not useful to the user and hence suppress it unless in
higher debug mode.

Change-ID: I78d7a7a6ecfa82a38a582b0d7b4da038355e3735
Signed-off-by: default avatarAnjali Singhai Jain <anjali.singhai@intel.com>
Tested-by: default avatarJim Young <jamesx.m.young@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent e99bdd39

drivers/net/ethernet/intel/i40e/i40e_txrx.c

+28 −10
Original line number Diff line number Diff line
@@ -228,8 +228,13 @@ static int i40e_add_del_fdir_udpv4(struct i40e_vsi *vsi, 
			 fd_data->pctype, fd_data->fd_id, ret);

		err = true;

	} else {

		if (add)

			dev_info(&pf->pdev->dev,

				 "Filter OK for PCTYPE %d loc = %d\n",

				 fd_data->pctype, fd_data->fd_id);

		else

			dev_info(&pf->pdev->dev,

			 "PCTYPE:%d, Filter send OK for fd_id:%d\n",

				 "Filter deleted for PCTYPE %d loc = %d\n",

				 fd_data->pctype, fd_data->fd_id);

	}

	return err ? -EOPNOTSUPP : 0;
@@ -290,8 +295,12 @@ static int i40e_add_del_fdir_tcpv4(struct i40e_vsi *vsi, 
			 fd_data->pctype, fd_data->fd_id, ret);

		err = true;

	} else {

		if (add)

			dev_info(&pf->pdev->dev, "Filter OK for PCTYPE %d loc = %d)\n",

				 fd_data->pctype, fd_data->fd_id);

		else

			dev_info(&pf->pdev->dev,

			 "PCTYPE:%d, Filter send OK for fd_id:%d\n",

				 "Filter deleted for PCTYPE %d loc = %d\n",

				 fd_data->pctype, fd_data->fd_id);

	}
@@ -359,8 +368,13 @@ static int i40e_add_del_fdir_ipv4(struct i40e_vsi *vsi, 
				 fd_data->pctype, fd_data->fd_id, ret);

			err = true;

		} else {

			if (add)

				dev_info(&pf->pdev->dev,

					 "Filter OK for PCTYPE %d loc = %d\n",

					 fd_data->pctype, fd_data->fd_id);

			else

				dev_info(&pf->pdev->dev,

				 "PCTYPE:%d, Filter send OK for fd_id:%d\n",

					 "Filter deleted for PCTYPE %d loc = %d\n",

					 fd_data->pctype, fd_data->fd_id);

		}

	}
@@ -443,6 +457,10 @@ static void i40e_fd_handle_status(struct i40e_ring *rx_ring, 
		I40E_RX_PROG_STATUS_DESC_QW1_ERROR_SHIFT;



	if (error == (0x1 << I40E_RX_PROG_STATUS_DESC_FD_TBL_FULL_SHIFT)) {

		if ((rx_desc->wb.qword0.hi_dword.fd_id != 0) ||

		    (I40E_DEBUG_FD & pf->hw.debug_mask))

			dev_warn(&pdev->dev, "ntuple filter loc = %d, could not be added\n",

				 rx_desc->wb.qword0.hi_dword.fd_id);



		/* filter programming failed most likely due to table full */

		fcnt_prog = i40e_get_cur_guaranteed_fd_count(pf);