Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7170e2e authored by Dan Carpenter's avatar Dan Carpenter Committed by Daniel Vetter
Browse files

drm/i915: fix a read size argument 



We want to read 3 bytes here, but because the parenthesis are in the
wrong place we instead read:

	sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd)

which is one byte.

Fixes: fe5a66f9 ("drm/i915: Read PSR caps/intermediate freqs/etc. only once on eDP")
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: <drm-intel-fixes@lists.freedesktop.org>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20161013085508.GJ16198@mwanda
parent ad16d2ed

drivers/gpu/drm/i915/intel_dp.c

+2 −2
Original line number Diff line number Diff line
@@ -3547,8 +3547,8 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp) 
	/* Read the eDP Display control capabilities registers */

	if ((intel_dp->dpcd[DP_EDP_CONFIGURATION_CAP] & DP_DPCD_DISPLAY_CONTROL_CAPABLE) &&

	    drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,

			     intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd) ==

			     sizeof(intel_dp->edp_dpcd)))

			     intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) ==

			     sizeof(intel_dp->edp_dpcd))

		DRM_DEBUG_KMS("EDP DPCD : %*ph\n", (int) sizeof(intel_dp->edp_dpcd),

			      intel_dp->edp_dpcd);