Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6f0083c authored by Colin Ian King's avatar Colin Ian King Committed by Mark Brown
Browse files

spi: armada-3700: fix unsigned compare than zero on irq 



spi->irq is an unsigned integer hence the check if status is less than
zero has no effect.  Fix this by replacing spi->irq with an int irq
so the less than zero compare will correctly detect errors.

Issue found with static analysis with CoverityScan, CID1388567

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarRomain Perier <romain.perier@free-electrons.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent fafd6794

drivers/spi/spi-armada-3700.c

+5 −4
Original line number Diff line number Diff line
@@ -800,7 +800,7 @@ static int a3700_spi_probe(struct platform_device *pdev) 
	struct spi_master *master;

	struct a3700_spi *spi;

	u32 num_cs = 0;

	int ret = 0;

	int irq, ret = 0;



	master = spi_alloc_master(dev, sizeof(*spi));

	if (!master) {
@@ -846,12 +846,13 @@ static int a3700_spi_probe(struct platform_device *pdev) 
		goto error;

	}



	spi->irq = platform_get_irq(pdev, 0);

	if (spi->irq < 0) {

		dev_err(dev, "could not get irq: %d\n", spi->irq);

	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_err(dev, "could not get irq: %d\n", irq);

		ret = -ENXIO;

		goto error;

	}

	spi->irq = irq;



	init_completion(&spi->done);