Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6a71105 authored by Jean Delvare's avatar Jean Delvare Committed by Jean Delvare
Browse files

i2c-dev: Delete empty detach_client callback 



Implementing detach_client is optional, so there is no point in
an empty implementation.

Likewise, i2c driver IDs are optional, and we don't need one.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
parent 954a9930

drivers/i2c/i2c-dev.c

+0 −7
Original line number Diff line number Diff line
@@ -548,19 +548,12 @@ static int i2cdev_detach_adapter(struct i2c_adapter *adap) 
	return 0;

}



static int i2cdev_detach_client(struct i2c_client *client)

{

	return 0;

}



static struct i2c_driver i2cdev_driver = {

	.driver = {

		.name	= "dev_driver",

	},

	.id		= I2C_DRIVERID_I2CDEV,

	.attach_adapter	= i2cdev_attach_adapter,

	.detach_adapter	= i2cdev_detach_adapter,

	.detach_client	= i2cdev_detach_client,

};



/* ------------------------------------------------------------------------- */

include/linux/i2c-id.h

+0 −2
Original line number Diff line number Diff line
@@ -91,8 +91,6 @@ 
#define I2C_DRIVERID_M52790 	95      /* Mitsubishi M52790SP/FP AV switch */

#define I2C_DRIVERID_CS5345	96	/* cs5345 audio processor	*/



#define I2C_DRIVERID_I2CDEV	900



#define I2C_DRIVERID_OV7670 1048	/* Omnivision 7670 camera */



/*