Commit f57cffb9 authored Dec 26, 2014 by Julia Lawall Committed by Mauro Carvalho Chehab Jan 27, 2015

[media] usbvision: Use setup_timer

Convert a call to init_timer and accompanying intializations of
the timer's data and function fields to a call to setup_timer.

A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression t,f,d;
@@

-init_timer(&t);
+setup_timer(&t,f,d);
-t.data = d;
-t.function = f;
// </smpl>

The semantic patch also changes the cast to long to a cast to unsigned
long in the data initializer, as unsigned long is the type of the data field.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

parent 8bf554ca

drivers/media/usb/usbvision/usbvision-core.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -2194,9 +2194,8 @@ static void usbvision_power_off_timer(unsigned long data)

		void usbvision_init_power_off_timer(struct usb_usbvision *usbvision)
		{
		init_timer(&usbvision->power_off_timer);
		usbvision->power_off_timer.data = (long)usbvision;
		usbvision->power_off_timer.function = usbvision_power_off_timer;
		setup_timer(&usbvision->power_off_timer, usbvision_power_off_timer,
		(unsigned long)usbvision);
		}

		void usbvision_set_power_off_timer(struct usb_usbvision *usbvision)