Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f57a1f3c authored by Aravind Gopalakrishnan's avatar Aravind Gopalakrishnan Committed by Ingo Molnar
Browse files

x86/mce/AMD: Fix LVT offset configuration for thresholding 



For processor families with the Scalable MCA feature, the LVT
offset for threshold interrupts is configured only in MSR
0xC0000410 and not in each per bank MISC register as was done in
earlier families.

Obtain the LVT offset from the correct MSR for those families.

Signed-off-by: default avatarAravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/1453750913-4781-7-git-send-email-bp@alien8.de


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 60f116fc

arch/x86/kernel/cpu/mcheck/mce_amd.c

+26 −1
Original line number Diff line number Diff line
@@ -49,6 +49,11 @@ 
#define DEF_LVT_OFF		0x2

#define DEF_INT_TYPE_APIC	0x2



/* Scalable MCA: */



/* Threshold LVT offset is at MSR0xC0000410[15:12] */

#define SMCA_THR_LVT_OFF	0xF000



static const char * const th_names[] = {

	"load_store",

	"insn_fetch",
@@ -142,6 +147,14 @@ static int lvt_off_valid(struct threshold_block *b, int apic, u32 lo, u32 hi) 
	}



	if (apic != msr) {

		/*

		 * On SMCA CPUs, LVT offset is programmed at a different MSR, and

		 * the BIOS provides the value. The original field where LVT offset

		 * was set is reserved. Return early here:

		 */

		if (mce_flags.smca)

			return 0;



		pr_err(FW_BUG "cpu %d, invalid threshold interrupt offset %d "

		       "for bank %d, block %d (MSR%08X=0x%x%08x)\n",

		       b->cpu, apic, b->bank, b->block, b->address, hi, lo);
@@ -300,7 +313,19 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c) 
				goto init;



			b.interrupt_enable = 1;



			if (mce_flags.smca) {

				u32 smca_low, smca_high;



				/* Gather LVT offset for thresholding: */

				if (rdmsr_safe(MSR_CU_DEF_ERR, &smca_low, &smca_high))

					break;



				new = (smca_low & SMCA_THR_LVT_OFF) >> 12;

			} else {

				new = (high & MASK_LVTOFF_HI) >> 20;

			}



			offset  = setup_APIC_mce_threshold(offset, new);



			if ((offset == new) &&