Commit f554ff80 authored Sep 27, 2011 by Amit Nagal Committed by Jiri Kosina Sep 27, 2011

HID: hidraw: open count should not increase if error



In hidraw_open, if hid_hw_power returns with error, hidraw device open count
should not increase.

Signed-off-by: Amit Nagal <helloin.amit@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 9561f7fa

drivers/hid/hidraw.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -272,8 +272,10 @@ static int hidraw_open(struct inode inode, struct file file)
		dev = hidraw_table[minor];
		if (!dev->open++) {
		err = hid_hw_power(dev->hid, PM_HINT_FULLON);
		if (err < 0)
		if (err < 0) {
		dev->open--;
		goto out_unlock;
		}

		err = hid_hw_open(dev->hid);
		if (err < 0) {