Commit f5001cea authored Apr 13, 2017 by WANG Cong Committed by David S. Miller Apr 17, 2017

kcm: remove a useless copy_from_user()



struct kcm_clone only contains fd, and kcm_clone() only
writes this struct, so there is no need to copy it from user.

Cc: Tom Herbert <tom@herbertland.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6b2af241

net/kcm/kcmsock.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1707,11 +1707,7 @@ static int kcm_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
		struct kcm_clone info;
		struct socket *newsock = NULL;

		if (copy_from_user(&info, (void __user *)arg, sizeof(info)))
		return -EFAULT;

		err = kcm_clone(sock, &info, &newsock);

		if (!err) {
		if (copy_to_user((void __user *)arg, &info,
		sizeof(info))) {