Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4cd8765 authored by Michael J. Ruhl's avatar Michael J. Ruhl Committed by Doug Ledford
Browse files

IB/hfi1: Name function prototype parameters 



To improve the readability of function prototypes, give the parameters
names.

Reviewed-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarMichael J. Ruhl <michael.j.ruhl@intel.com>
Signed-off-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 224d71f9

drivers/infiniband/hw/hfi1/chip.c

+4 −4
Original line number Diff line number Diff line
@@ -1055,7 +1055,7 @@ static void handle_pio_err(struct hfi1_devdata *dd, u32 unused, u64 reg); 
static void handle_sdma_err(struct hfi1_devdata *dd, u32 unused, u64 reg);

static void handle_egress_err(struct hfi1_devdata *dd, u32 unused, u64 reg);

static void handle_txe_err(struct hfi1_devdata *dd, u32 unused, u64 reg);

static void set_partition_keys(struct hfi1_pportdata *);

static void set_partition_keys(struct hfi1_pportdata *ppd);

static const char *link_state_name(u32 state);

static const char *link_state_reason_name(struct hfi1_pportdata *ppd,

					  u32 state);
@@ -1068,9 +1068,9 @@ static int wait_logical_linkstate(struct hfi1_pportdata *ppd, u32 state, 
				  int msecs);

static void read_planned_down_reason_code(struct hfi1_devdata *dd, u8 *pdrrc);

static void read_link_down_reason(struct hfi1_devdata *dd, u8 *ldr);

static void handle_temp_err(struct hfi1_devdata *);

static void dc_shutdown(struct hfi1_devdata *);

static void dc_start(struct hfi1_devdata *);

static void handle_temp_err(struct hfi1_devdata *dd);

static void dc_shutdown(struct hfi1_devdata *dd);

static void dc_start(struct hfi1_devdata *dd);

static int qos_rmt_entries(struct hfi1_devdata *dd, unsigned int *mp,

			   unsigned int *np);

static void clear_full_mgmt_pkey(struct hfi1_pportdata *ppd);

drivers/infiniband/hw/hfi1/chip.h

+4 −2
Original line number Diff line number Diff line
@@ -636,7 +636,8 @@ static inline void write_uctxt_csr(struct hfi1_devdata *dd, int ctxt, 
	write_csr(dd, offset0 + (0x1000 * ctxt), value);

}



u64 create_pbc(struct hfi1_pportdata *ppd, u64, int, u32, u32);

u64 create_pbc(struct hfi1_pportdata *ppd, u64 flags, int srate_mbs, u32 vl,

	       u32 dw_len);



/* firmware.c */

#define SBUS_MASTER_BROADCAST 0xfd
@@ -728,7 +729,8 @@ int bringup_serdes(struct hfi1_pportdata *ppd); 
void set_intr_state(struct hfi1_devdata *dd, u32 enable);

void apply_link_downgrade_policy(struct hfi1_pportdata *ppd,

				 int refresh_widths);

void update_usrhead(struct hfi1_ctxtdata *, u32, u32, u32, u32, u32);

void update_usrhead(struct hfi1_ctxtdata *rcd, u32 hd, u32 updegr, u32 egrhd,

		    u32 intr_adjust, u32 npkts);

int stop_drain_data_vls(struct hfi1_devdata *dd);

int open_fill_data_vls(struct hfi1_devdata *dd);

u32 ns_to_cclock(struct hfi1_devdata *dd, u32 ns);

drivers/infiniband/hw/hfi1/driver.c

+2 −2
Original line number Diff line number Diff line
@@ -85,8 +85,8 @@ module_param_named(cu, hfi1_cu, uint, S_IRUGO); 
MODULE_PARM_DESC(cu, "Credit return units");



unsigned long hfi1_cap_mask = HFI1_CAP_MASK_DEFAULT;

static int hfi1_caps_set(const char *, const struct kernel_param *);

static int hfi1_caps_get(char *, const struct kernel_param *);

static int hfi1_caps_set(const char *val, const struct kernel_param *kp);

static int hfi1_caps_get(char *buffer, const struct kernel_param *kp);

static const struct kernel_param_ops cap_ops = {

	.set = hfi1_caps_set,

	.get = hfi1_caps_get

drivers/infiniband/hw/hfi1/file_ops.c

+30 −24
Original line number Diff line number Diff line
@@ -70,30 +70,36 @@ 
/*

 * File operation functions

 */

static int hfi1_file_open(struct inode *, struct file *);

static int hfi1_file_close(struct inode *, struct file *);

static ssize_t hfi1_write_iter(struct kiocb *, struct iov_iter *);

static unsigned int hfi1_poll(struct file *, struct poll_table_struct *);

static int hfi1_file_mmap(struct file *, struct vm_area_struct *);



static u64 kvirt_to_phys(void *);

static int assign_ctxt(struct file *, struct hfi1_user_info *);

static int init_subctxts(struct hfi1_ctxtdata *, const struct hfi1_user_info *);

static int user_init(struct file *);

static int get_ctxt_info(struct file *, void __user *, __u32);

static int get_base_info(struct file *, void __user *, __u32);

static int setup_ctxt(struct file *);

static int setup_subctxt(struct hfi1_ctxtdata *);

static int get_user_context(struct file *, struct hfi1_user_info *, int);

static int find_shared_ctxt(struct file *, const struct hfi1_user_info *);

static int allocate_ctxt(struct file *, struct hfi1_devdata *,

			 struct hfi1_user_info *);

static unsigned int poll_urgent(struct file *, struct poll_table_struct *);

static unsigned int poll_next(struct file *, struct poll_table_struct *);

static int user_event_ack(struct hfi1_ctxtdata *, int, unsigned long);

static int set_ctxt_pkey(struct hfi1_ctxtdata *, unsigned, u16);

static int manage_rcvq(struct hfi1_ctxtdata *, unsigned, int);

static int vma_fault(struct vm_fault *);

static int hfi1_file_open(struct inode *inode, struct file *fp);

static int hfi1_file_close(struct inode *inode, struct file *fp);

static ssize_t hfi1_write_iter(struct kiocb *kiocb, struct iov_iter *from);

static unsigned int hfi1_poll(struct file *fp, struct poll_table_struct *pt);

static int hfi1_file_mmap(struct file *fp, struct vm_area_struct *vma);



static u64 kvirt_to_phys(void *addr);

static int assign_ctxt(struct file *fp, struct hfi1_user_info *uinfo);

static int init_subctxts(struct hfi1_ctxtdata *uctxt,

			 const struct hfi1_user_info *uinfo);

static int user_init(struct file *fp);

static int get_ctxt_info(struct file *fp, void __user *ubase, __u32 len);

static int get_base_info(struct file *fp, void __user *ubase, __u32 len);

static int setup_ctxt(struct file *fp);

static int setup_subctxt(struct hfi1_ctxtdata *uctxt);

static int get_user_context(struct file *fp, struct hfi1_user_info *uinfo,

			    int devno);

static int find_shared_ctxt(struct file *fp,

			    const struct hfi1_user_info *uinfo);

static int allocate_ctxt(struct file *fp, struct hfi1_devdata *dd,

			 struct hfi1_user_info *uinfo);

static unsigned int poll_urgent(struct file *fp, struct poll_table_struct *pt);

static unsigned int poll_next(struct file *fp, struct poll_table_struct *pt);

static int user_event_ack(struct hfi1_ctxtdata *uctxt, int subctxt,

			  unsigned long events);

static int set_ctxt_pkey(struct hfi1_ctxtdata *uctxt, unsigned subctxt,

			 u16 pkey);

static int manage_rcvq(struct hfi1_ctxtdata *uctxt, unsigned subctxt,

		       int start_stop);

static int vma_fault(struct vm_fault *vmf);

static long hfi1_file_ioctl(struct file *fp, unsigned int cmd,

			    unsigned long arg);

drivers/infiniband/hw/hfi1/hfi.h

+37 −35
Original line number Diff line number Diff line
@@ -1263,27 +1263,28 @@ struct hfi1_devdata *hfi1_lookup(int unit); 
extern u32 hfi1_cpulist_count;

extern unsigned long *hfi1_cpulist;



int hfi1_init(struct hfi1_devdata *, int);

int hfi1_init(struct hfi1_devdata *dd, int reinit);

int hfi1_count_units(int *npresentp, int *nupp);

int hfi1_count_active_units(void);



int hfi1_diag_add(struct hfi1_devdata *);

void hfi1_diag_remove(struct hfi1_devdata *);

int hfi1_diag_add(struct hfi1_devdata *dd);

void hfi1_diag_remove(struct hfi1_devdata *dd);

void handle_linkup_change(struct hfi1_devdata *dd, u32 linkup);



void handle_user_interrupt(struct hfi1_ctxtdata *rcd);



int hfi1_create_rcvhdrq(struct hfi1_devdata *, struct hfi1_ctxtdata *);

int hfi1_setup_eagerbufs(struct hfi1_ctxtdata *);

int hfi1_create_rcvhdrq(struct hfi1_devdata *dd, struct hfi1_ctxtdata *rcd);

int hfi1_setup_eagerbufs(struct hfi1_ctxtdata *rcd);

int hfi1_create_ctxts(struct hfi1_devdata *dd);

struct hfi1_ctxtdata *hfi1_create_ctxtdata(struct hfi1_pportdata *, u32, int);

void hfi1_init_pportdata(struct pci_dev *, struct hfi1_pportdata *,

			 struct hfi1_devdata *, u8, u8);

void hfi1_free_ctxtdata(struct hfi1_devdata *, struct hfi1_ctxtdata *);



int handle_receive_interrupt(struct hfi1_ctxtdata *, int);

int handle_receive_interrupt_nodma_rtail(struct hfi1_ctxtdata *, int);

int handle_receive_interrupt_dma_rtail(struct hfi1_ctxtdata *, int);

struct hfi1_ctxtdata *hfi1_create_ctxtdata(struct hfi1_pportdata *ppd, u32 ctxt,

					   int numa);

void hfi1_init_pportdata(struct pci_dev *pdev, struct hfi1_pportdata *ppd,

			 struct hfi1_devdata *dd, u8 hw_pidx, u8 port);

void hfi1_free_ctxtdata(struct hfi1_devdata *dd, struct hfi1_ctxtdata *rcd);



int handle_receive_interrupt(struct hfi1_ctxtdata *rcd, int thread);

int handle_receive_interrupt_nodma_rtail(struct hfi1_ctxtdata *rcd, int thread);

int handle_receive_interrupt_dma_rtail(struct hfi1_ctxtdata *rcd, int thread);

void set_all_slowpath(struct hfi1_devdata *dd);

void hfi1_vnic_synchronize_irq(struct hfi1_devdata *dd);

void hfi1_set_vnic_msix_info(struct hfi1_ctxtdata *rcd);
@@ -1580,7 +1581,7 @@ static inline int rcv_pkey_check(struct hfi1_pportdata *ppd, u16 pkey, 


u32 lrh_max_header_bytes(struct hfi1_devdata *dd);

int mtu_to_enum(u32 mtu, int default_if_bad);

u16 enum_to_mtu(int);

u16 enum_to_mtu(int mtu);

static inline int valid_ib_mtu(unsigned int mtu)

{

	return mtu == 256 || mtu == 512 ||
@@ -1594,15 +1595,15 @@ static inline int valid_opa_max_mtu(unsigned int mtu) 
		(valid_ib_mtu(mtu) || mtu == 8192 || mtu == 10240);

}



int set_mtu(struct hfi1_pportdata *);

int set_mtu(struct hfi1_pportdata *ppd);



int hfi1_set_lid(struct hfi1_pportdata *, u32, u8);

void hfi1_disable_after_error(struct hfi1_devdata *);

int hfi1_set_uevent_bits(struct hfi1_pportdata *, const int);

int hfi1_rcvbuf_validate(u32, u8, u16 *);

int hfi1_set_lid(struct hfi1_pportdata *ppd, u32 lid, u8 lmc);

void hfi1_disable_after_error(struct hfi1_devdata *dd);

int hfi1_set_uevent_bits(struct hfi1_pportdata *ppd, const int evtbit);

int hfi1_rcvbuf_validate(u32 size, u8 type, u16 *encode);



int fm_get_table(struct hfi1_pportdata *, int, void *);

int fm_set_table(struct hfi1_pportdata *, int, void *);

int fm_get_table(struct hfi1_pportdata *ppd, int which, void *t);

int fm_set_table(struct hfi1_pportdata *ppd, int which, void *t);



void set_up_vl15(struct hfi1_devdata *dd, u8 vau, u16 vl15buf);

void reset_link_credits(struct hfi1_devdata *dd);
@@ -1734,9 +1735,9 @@ struct cc_state *get_cc_state_protected(struct hfi1_pportdata *ppd) 
#define HFI1_CTXT_WAITING_URG 5



/* free up any allocated data at closes */

struct hfi1_devdata *hfi1_init_dd(struct pci_dev *,

				  const struct pci_device_id *);

void hfi1_free_devdata(struct hfi1_devdata *);

struct hfi1_devdata *hfi1_init_dd(struct pci_dev *pdev,

				  const struct pci_device_id *ent);

void hfi1_free_devdata(struct hfi1_devdata *dd);

struct hfi1_devdata *hfi1_alloc_devdata(struct pci_dev *pdev, size_t extra);



/* LED beaconing functions */
@@ -1811,24 +1812,25 @@ static inline u32 get_rcvhdrtail(const struct hfi1_ctxtdata *rcd) 


extern const char ib_hfi1_version[];



int hfi1_device_create(struct hfi1_devdata *);

void hfi1_device_remove(struct hfi1_devdata *);

int hfi1_device_create(struct hfi1_devdata *dd);

void hfi1_device_remove(struct hfi1_devdata *dd);



int hfi1_create_port_files(struct ib_device *ibdev, u8 port_num,

			   struct kobject *kobj);

int hfi1_verbs_register_sysfs(struct hfi1_devdata *);

void hfi1_verbs_unregister_sysfs(struct hfi1_devdata *);

int hfi1_verbs_register_sysfs(struct hfi1_devdata *dd);

void hfi1_verbs_unregister_sysfs(struct hfi1_devdata *dd);

/* Hook for sysfs read of QSFP */

int qsfp_dump(struct hfi1_pportdata *ppd, char *buf, int len);



int hfi1_pcie_init(struct pci_dev *, const struct pci_device_id *);

void hfi1_pcie_cleanup(struct pci_dev *);

int hfi1_pcie_ddinit(struct hfi1_devdata *, struct pci_dev *);

int hfi1_pcie_init(struct pci_dev *pdev, const struct pci_device_id *ent);

void hfi1_pcie_cleanup(struct pci_dev *pdev);

int hfi1_pcie_ddinit(struct hfi1_devdata *dd, struct pci_dev *pdev);

void hfi1_pcie_ddcleanup(struct hfi1_devdata *);

void hfi1_pcie_flr(struct hfi1_devdata *);

int pcie_speeds(struct hfi1_devdata *);

void request_msix(struct hfi1_devdata *, u32 *, struct hfi1_msix_entry *);

void hfi1_enable_intx(struct pci_dev *);

void hfi1_pcie_flr(struct hfi1_devdata *dd);

int pcie_speeds(struct hfi1_devdata *dd);

void request_msix(struct hfi1_devdata *dd, u32 *nent,

		  struct hfi1_msix_entry *entry);

void hfi1_enable_intx(struct pci_dev *pdev);

void restore_pci_variables(struct hfi1_devdata *dd);

int do_pcie_gen3_transition(struct hfi1_devdata *dd);

int parse_platform_config(struct hfi1_devdata *dd);