Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4b4718b authored by Dave Airlie's avatar Dave Airlie
Browse files

drm: ast,cirrus,mgag200: use drm_can_sleep 



these 3 were checking in_interrupt but we have situations where
calling vunmap under this could cause a BUG to be hit in
smp_call_function_many. Use the drm_can_sleep macro instead,
which should stop this path from been taken in this case.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 821b4db3

drivers/gpu/drm/ast/ast_fb.c

+1 −1
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ static void ast_dirty_update(struct ast_fbdev *afbdev, 
	 * then the BO is being moved and we should

	 * store up the damage until later.

	 */

	if (!in_interrupt())

	if (!drm_can_sleep())

		ret = ast_bo_reserve(bo, true);

	if (ret) {

		if (ret != -EBUSY)

drivers/gpu/drm/cirrus/cirrus_fbdev.c

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ static void cirrus_dirty_update(struct cirrus_fbdev *afbdev, 
	 * then the BO is being moved and we should

	 * store up the damage until later.

	 */

	if (!in_interrupt())

	if (!drm_can_sleep())

		ret = cirrus_bo_reserve(bo, true);

	if (ret) {

		if (ret != -EBUSY)

drivers/gpu/drm/mgag200/mgag200_fb.c

+1 −1
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ static void mga_dirty_update(struct mga_fbdev *mfbdev, 
	 * then the BO is being moved and we should

	 * store up the damage until later.

	 */

	if (!in_interrupt())

	if (!drm_can_sleep())

		ret = mgag200_bo_reserve(bo, true);

	if (ret) {

		if (ret != -EBUSY)