Commit f45f3c1f authored Aug 18, 2010 by Johannes Berg Committed by Greg Kroah-Hartman Aug 23, 2010

firmware_class: fix typo in error path



In the error path, _request_firmware sets
firmware_p to NULL rather than *firmware_p,
which leads to passing a freed firmware
struct to drivers when the firmware file
cannot be found. Fix this.

Broken by commit f8a4bd34.

Reported-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 8488a38f

drivers/base/firmware_class.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -568,7 +568,7 @@ static int _request_firmware(const struct firmware **firmware_p,
		out:
		if (retval) {
		release_firmware(firmware);
		firmware_p = NULL;
		*firmware_p = NULL;
		}

		return retval;