Commit f443ddf1 authored Jul 31, 2006 by Alan Stern Committed by Greg Kroah-Hartman Aug 02, 2006

USB: UHCI: Don't test the Short Packet Detect bit



Apparently some UHCI controllers change the value of the Short Packet
Detect (SPD) bit in the TD status word -- presumably when they receive a
short packet.  This patch (as759) changes uhci-hcd to avoid assuming
that the bit is unchanged; in fact, the driver no longer looks at SPD at
all.

This fixes the second problem reported in Bugzilla #6752.


Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent de1caa47

drivers/usb/host/uhci-q.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -943,7 +943,9 @@ static int uhci_result_common(struct uhci_hcd uhci, struct urb urb)
		/* We received a short packet */
		if (urb->transfer_flags & URB_SHORT_NOT_OK)
		ret = -EREMOTEIO;
		else if (ctrlstat & TD_CTRL_SPD)

		/* Fixup needed only if this isn't the URB's last TD */
		else if (&td->list != urbp->td_list.prev)
		ret = 1;
		}