Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4353daf authored by Andri Yngvason's avatar Andri Yngvason Committed by Marc Kleine-Budde
Browse files

can: cc770: Fix stalls on rt-linux, remove redundant IRQ ack 



This has been reported to cause stalls on rt-linux.

Suggested-by: default avatarRichard Weinberger <richard@nod.at>
Tested-by: default avatarRichard Weinberger <richard@nod.at>
Signed-off-by: default avatarAndri Yngvason <andri.yngvason@marel.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent f89782c2

drivers/net/can/cc770/cc770.c

+0 −15
Original line number Diff line number Diff line
@@ -447,15 +447,6 @@ static netdev_tx_t cc770_start_xmit(struct sk_buff *skb, struct net_device *dev) 


	stats->tx_bytes += dlc;





	/*

	 * HM: We had some cases of repeated IRQs so make sure the

	 * INT is acknowledged I know it's already further up, but

	 * doing again fixed the issue

	 */

	cc770_write_reg(priv, msgobj[mo].ctrl0,

			MSGVAL_UNC | TXIE_UNC | RXIE_UNC | INTPND_RES);



	return NETDEV_TX_OK;

}
@@ -684,12 +675,6 @@ static void cc770_tx_interrupt(struct net_device *dev, unsigned int o) 
	/* Nothing more to send, switch off interrupts */

	cc770_write_reg(priv, msgobj[mo].ctrl0,

			MSGVAL_RES | TXIE_RES | RXIE_RES | INTPND_RES);

	/*

	 * We had some cases of repeated IRQ so make sure the

	 * INT is acknowledged

	 */

	cc770_write_reg(priv, msgobj[mo].ctrl0,

			MSGVAL_UNC | TXIE_UNC | RXIE_UNC | INTPND_RES);



	stats->tx_packets++;

	can_get_echo_skb(dev, 0);