Commit f40faf62 authored Jun 07, 2014 by Andy Lutomirski Committed by Emmanuel Grumbach Jun 24, 2014

iwlwifi: pcie: improve debugfs queue info



This adds need_update and write_actual to rx_queue and need_update
and an HCMD indicator to tx_queue.

On my card, rx_queue now looks like:

read: 181
write: 180
write_actual: 176
need_update: 0
free_count: 40
closed_rb_num: 181

tx_queue now looks like:

hwq 00: read=29 write=30 use=1 stop=0 need_update=0
hwq 01: read=0 write=0 use=1 stop=0 need_update=0
hwq 02: read=128 write=128 use=1 stop=0 need_update=0
hwq 03: read=0 write=0 use=1 stop=0 need_update=0
hwq 04: read=94 write=94 use=1 stop=0 need_update=0 HCMD
hwq 05: read=0 write=0 use=0 stop=0 need_update=0
hwq 06: read=0 write=0 use=0 stop=0 need_update=0
hwq 07: read=0 write=0 use=0 stop=0 need_update=0
hwq 08: read=0 write=0 use=0 stop=0 need_update=0
hwq 09: read=0 write=0 use=0 stop=0 need_update=0
hwq 10: read=0 write=0 use=0 stop=0 need_update=0
hwq 11: read=0 write=0 use=0 stop=0 need_update=0
hwq 12: read=0 write=0 use=0 stop=0 need_update=0
hwq 13: read=0 write=0 use=0 stop=0 need_update=0
hwq 14: read=0 write=0 use=0 stop=0 need_update=0
hwq 15: read=0 write=0 use=0 stop=0 need_update=0
hwq 16: read=0 write=0 use=0 stop=0 need_update=0
hwq 17: read=0 write=0 use=0 stop=0 need_update=0
hwq 18: read=0 write=0 use=0 stop=0 need_update=0
hwq 19: read=0 write=0 use=0 stop=0 need_update=0

This may help with debugging queue stalls.

Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

parent d536c32b

drivers/net/wireless/iwlwifi/pcie/trans.c

+8 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1573,10 +1573,12 @@ static ssize_t iwl_dbgfs_tx_queue_read(struct file *file,
	txq = &trans_pcie->txq[cnt];		txq = &trans_pcie->txq[cnt];
	q = &txq->q;		q = &txq->q;
	pos += scnprintf(buf + pos, bufsz - pos,		pos += scnprintf(buf + pos, bufsz - pos,
	"hwq %.2d: read=%u write=%u use=%d stop=%d\n",		"hwq %.2d: read=%u write=%u use=%d stop=%d need_update=%d%s\n",
	cnt, q->read_ptr, q->write_ptr,		cnt, q->read_ptr, q->write_ptr,
	!!test_bit(cnt, trans_pcie->queue_used),		!!test_bit(cnt, trans_pcie->queue_used),
	!!test_bit(cnt, trans_pcie->queue_stopped));		!!test_bit(cnt, trans_pcie->queue_stopped),
			txq->need_update,
			(cnt == trans_pcie->cmd_queue ? " HCMD" : ""));
	}		}
	ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);		ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);
	kfree(buf);		kfree(buf);
	@@ -1598,6 +1600,10 @@ static ssize_t iwl_dbgfs_rx_queue_read(struct file *file,
	rxq->read);		rxq->read);
	pos += scnprintf(buf + pos, bufsz - pos, "write: %u\n",		pos += scnprintf(buf + pos, bufsz - pos, "write: %u\n",
	rxq->write);		rxq->write);
			pos += scnprintf(buf + pos, bufsz - pos, "write_actual: %u\n",
			rxq->write_actual);
			pos += scnprintf(buf + pos, bufsz - pos, "need_update: %d\n",
			rxq->need_update);
	pos += scnprintf(buf + pos, bufsz - pos, "free_count: %u\n",		pos += scnprintf(buf + pos, bufsz - pos, "free_count: %u\n",
	rxq->free_count);		rxq->free_count);
	if (rxq->rb_stts) {		if (rxq->rb_stts) {