Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3c77d63 authored by Archit Taneja's avatar Archit Taneja Committed by Tomi Valkeinen
Browse files

OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store() 



The function overlay_manager_store currently fails if the sysfs input is a
prefix string of an existing overlay manager name. This occurs because strncmp
compares the two strings only till the length of the input sysfs string. So a
sysfs input "lcd" will match manager name "lcd2" which is incorrect behavior.

The use of sysfs_streq here will prevent this false positive match to occur.

Signed-off-by: default avatarArchit Taneja <archit@ti.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@nokia.com>
parent e9c31afc

drivers/video/omap2/dss/overlay.c

+1 −1
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ static ssize_t overlay_manager_store(struct omap_overlay *ovl, const char *buf, 
		for (i = 0; i < omap_dss_get_num_overlay_managers(); ++i) {

			mgr = omap_dss_get_overlay_manager(i);



			if (strncmp(buf, mgr->name, len) == 0)

			if (sysfs_streq(buf, mgr->name))

				break;



			mgr = NULL;