Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3556254 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Al Viro
Browse files

ubifs: fix bogus __mark_inode_dirty(I_DIRTY_SYNC | I_DIRTY_DATASYNC) call 



I_DIRTY_DATASYNC is a strict superset of I_DIRTY_SYNC semantics, as
in mark dirty to be written out by fdatasync as well.  So dirtying
for both flags makes no sense.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 2c2acd2d

fs/ubifs/file.c

+1 −1
Original line number Diff line number Diff line
@@ -1256,7 +1256,7 @@ static int do_setattr(struct ubifs_info *c, struct inode *inode, 
		 * Inode length changed, so we have to make sure

		 * @I_DIRTY_DATASYNC is set.

		 */

		 __mark_inode_dirty(inode, I_DIRTY_SYNC | I_DIRTY_DATASYNC);

		 __mark_inode_dirty(inode, I_DIRTY_DATASYNC);

	else

		mark_inode_dirty_sync(inode);

	mutex_unlock(&ui->ui_mutex);