Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f31877a1 authored by Takashi Iwai's avatar Takashi Iwai Committed by Mark Brown
Browse files

ASoC: cs43130: Fix possible Oops with invalid dev_id 



As compiler spotted out, there is the potential NULL-dereference in
the code when dc-measure OF is given for other than 43130/43131:
  sound/soc/codecs/cs43130.c:2089:18: warning: ‘hpload_seq’ may be used uninitialized in this function [-Wmaybe-uninitialized]

Warn it and return before triggering Oops.

Fixes: 8f1e5bf9 ("ASoC: cs43130: Add support for CS43130 codec")
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 83ef26ac

sound/soc/codecs/cs43130.c

+4 −0
Original line number Diff line number Diff line
@@ -2079,6 +2079,10 @@ static void cs43130_imp_meas(struct work_struct *wk) 
	case CS43131_CHIP_ID:

		hpload_seq = hpload_seq2;

		seq_size = ARRAY_SIZE(hpload_seq2);

		break;

	default:

		WARN(1, "Invalid dev_id for meas: %d", cs43130->dev_id);

		return;

	}



	i = 0;