Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f27fb2ef authored by Mike Christie's avatar Mike Christie Committed by James Bottomley
Browse files

[SCSI] iscsi class: sysfs group is_visible callout for iscsi host attrs 



The iscsi class currently does not support writable sysfs
attrs for LLD sysfs settings. This patch converts the
iscsi class and driver's host attrs to use the attribute
container sysfs group and the sysfs group's is_visible callout
to be able to support readable or writable sysfs attrs.

Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent b78dbba0

drivers/infiniband/ulp/iser/iscsi_iser.c

+9 −3
Original line number Diff line number Diff line
@@ -635,6 +635,15 @@ iscsi_iser_ep_disconnect(struct iscsi_endpoint *ep) 
static mode_t iser_attr_is_visible(int param_type, int param)

{

	switch (param_type) {

	case ISCSI_HOST_PARAM:

		switch (param) {

		case ISCSI_HOST_PARAM_NETDEV_NAME:

		case ISCSI_HOST_PARAM_HWADDRESS:

		case ISCSI_HOST_PARAM_INITIATOR_NAME:

			return S_IRUGO;

		default:

			return 0;

		}

	case ISCSI_PARAM:

		switch (param) {

		case ISCSI_PARAM_MAX_RECV_DLENGTH:
@@ -697,9 +706,6 @@ static struct iscsi_transport iscsi_iser_transport = { 
	.owner                  = THIS_MODULE,

	.name                   = "iser",

	.caps                   = CAP_RECOVERY_L0 | CAP_MULTI_R2T,

	.host_param_mask	= ISCSI_HOST_HWADDRESS |

				  ISCSI_HOST_NETDEV_NAME |

				  ISCSI_HOST_INITIATOR_NAME,

	/* session management */

	.create_session         = iscsi_iser_session_create,

	.destroy_session        = iscsi_iser_session_destroy,

drivers/scsi/be2iscsi/be_iscsi.c

+9 −0
Original line number Diff line number Diff line
@@ -737,6 +737,15 @@ void beiscsi_ep_disconnect(struct iscsi_endpoint *ep) 
mode_t be2iscsi_attr_is_visible(int param_type, int param)

{

	switch (param_type) {

	case ISCSI_HOST_PARAM:

		switch (param) {

		case ISCSI_HOST_PARAM_HWADDRESS:

		case ISCSI_HOST_PARAM_IPADDRESS:

		case ISCSI_HOST_PARAM_INITIATOR_NAME:

			return S_IRUGO;

		default:

			return 0;

		}

	case ISCSI_PARAM:

		switch (param) {

		case ISCSI_PARAM_MAX_RECV_DLENGTH:

drivers/scsi/be2iscsi/be_main.c

+0 −2
Original line number Diff line number Diff line
@@ -4364,8 +4364,6 @@ struct iscsi_transport beiscsi_iscsi_transport = { 
	.name = DRV_NAME,

	.caps = CAP_RECOVERY_L0 | CAP_HDRDGST | CAP_TEXT_NEGO |

		CAP_MULTI_R2T | CAP_DATADGST | CAP_DATA_PATH_OFFLOAD,

	.host_param_mask = ISCSI_HOST_HWADDRESS | ISCSI_HOST_IPADDRESS |

				ISCSI_HOST_INITIATOR_NAME,

	.create_session = beiscsi_session_create,

	.destroy_session = beiscsi_session_destroy,

	.create_conn = beiscsi_conn_create,

drivers/scsi/bnx2i/bnx2i_iscsi.c

+9 −2
Original line number Diff line number Diff line
@@ -2180,6 +2180,15 @@ static int bnx2i_nl_set_path(struct Scsi_Host *shost, struct iscsi_path *params) 
static mode_t bnx2i_attr_is_visible(int param_type, int param)

{

	switch (param_type) {

	case ISCSI_HOST_PARAM:

		switch (param) {

		case ISCSI_HOST_PARAM_NETDEV_NAME:

		case ISCSI_HOST_PARAM_HWADDRESS:

		case ISCSI_HOST_PARAM_IPADDRESS:

			return S_IRUGO;

		default:

			return 0;

		}

	case ISCSI_PARAM:

		switch (param) {

		case ISCSI_PARAM_MAX_RECV_DLENGTH:
@@ -2251,8 +2260,6 @@ struct iscsi_transport bnx2i_iscsi_transport = { 
				  CAP_MULTI_R2T | CAP_DATADGST |

				  CAP_DATA_PATH_OFFLOAD |

				  CAP_TEXT_NEGO,

	.host_param_mask	= ISCSI_HOST_HWADDRESS | ISCSI_HOST_IPADDRESS |

				  ISCSI_HOST_NETDEV_NAME,

	.create_session		= bnx2i_session_create,

	.destroy_session	= bnx2i_session_destroy,

	.create_conn		= bnx2i_conn_create,

drivers/scsi/cxgbi/cxgb3i/cxgb3i.c

+0 −3
Original line number Diff line number Diff line
@@ -106,9 +106,6 @@ static struct iscsi_transport cxgb3i_iscsi_transport = { 
	.caps		= CAP_RECOVERY_L0 | CAP_MULTI_R2T | CAP_HDRDGST

				| CAP_DATADGST | CAP_DIGEST_OFFLOAD |

				CAP_PADDING_OFFLOAD | CAP_TEXT_NEGO,

	.host_param_mask	= ISCSI_HOST_HWADDRESS | ISCSI_HOST_IPADDRESS |

				ISCSI_HOST_INITIATOR_NAME |

				ISCSI_HOST_NETDEV_NAME,

	.attr_is_visible	= cxgbi_attr_is_visible,

	.get_host_param	= cxgbi_get_host_param,

	.set_host_param	= cxgbi_set_host_param,