Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2462e03 authored by Lad Prabhakar's avatar Lad Prabhakar Committed by Greg Kroah-Hartman
Browse files

can: rcar_canfd: rcar_canfd_channel_probe(): register the CAN device when fully ready 

[ Upstream commit c5048a7b2c23ab589f3476a783bd586b663eda5b ]

Register the CAN device only when all the necessary initialization is
completed. This patch makes sure all the data structures and locks are
initialized before registering the CAN device.

Link: https://lore.kernel.org/all/20220221225935.12300-1-prabhakar.mahadev-lad.rj@bp.renesas.com


Reported-by: default avatarPavel Machek <pavel@denx.de>
Signed-off-by: default avatarLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: default avatarPavel Machek <pavel@denx.de>
Reviewed-by: default avatarUlrich Hecht <uli+renesas@fpond.eu>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d00275fb

drivers/net/can/rcar/rcar_canfd.c

+3 −3
Original line number Diff line number Diff line
@@ -1602,15 +1602,15 @@ static int rcar_canfd_channel_probe(struct rcar_canfd_global *gpriv, u32 ch, 


	netif_napi_add(ndev, &priv->napi, rcar_canfd_rx_poll,

		       RCANFD_NAPI_WEIGHT);

	spin_lock_init(&priv->tx_lock);

	devm_can_led_init(ndev);

	gpriv->ch[priv->channel] = priv;

	err = register_candev(ndev);

	if (err) {

		dev_err(&pdev->dev,

			"register_candev() failed, error %d\n", err);

		goto fail_candev;

	}

	spin_lock_init(&priv->tx_lock);

	devm_can_led_init(ndev);

	gpriv->ch[priv->channel] = priv;

	dev_info(&pdev->dev, "device registered (channel %u)\n", priv->channel);

	return 0;