Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f241e749 authored by Jack Morgenstein's avatar Jack Morgenstein Committed by David S. Miller
Browse files

mlx5: minor fixes (mainly avoidance of hidden casts) 



There were many places where parameters which should be u8/u16 were
integer type.

Additionally, in 2 places, a check for a non-null pointer was added
before dereferencing the pointer (this is actually a bug fix).

Signed-off-by: default avatarJack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: default avatarEli Cohen <eli@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9603b61d

drivers/infiniband/hw/mlx5/cq.c

+1 −1
Original line number Diff line number Diff line
@@ -348,7 +348,7 @@ static void handle_atomic(struct mlx5_ib_qp *qp, struct mlx5_cqe64 *cqe64, 
static void handle_atomics(struct mlx5_ib_qp *qp, struct mlx5_cqe64 *cqe64,

			   u16 tail, u16 head)

{

	int idx;

	u16 idx;



	do {

		idx = tail & (qp->sq.wqe_cnt - 1);

drivers/infiniband/hw/mlx5/mad.c

+1 −1
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ enum { 
};



int mlx5_MAD_IFC(struct mlx5_ib_dev *dev, int ignore_mkey, int ignore_bkey,

		 int port, struct ib_wc *in_wc, struct ib_grh *in_grh,

		 u8 port, struct ib_wc *in_wc, struct ib_grh *in_grh,

		 void *in_mad, void *response_mad)

{

	u8 op_modifier = 0;

drivers/infiniband/hw/mlx5/main.c

+1 −1
Original line number Diff line number Diff line
@@ -478,7 +478,7 @@ static struct ib_ucontext *mlx5_ib_alloc_ucontext(struct ib_device *ibdev, 
	int uuarn;

	int err;

	int i;

	int reqlen;

	size_t reqlen;



	if (!dev->ib_active)

		return ERR_PTR(-EAGAIN);

drivers/infiniband/hw/mlx5/mem.c

+1 −1
Original line number Diff line number Diff line
@@ -148,7 +148,7 @@ int mlx5_ib_get_buf_offset(u64 addr, int page_shift, u32 *offset) 
	u64 off_mask;

	u64 buf_off;



	page_size = 1 << page_shift;

	page_size = (u64)1 << page_shift;

	page_mask = page_size - 1;

	buf_off = addr & page_mask;

	off_size = page_size >> 6;

drivers/infiniband/hw/mlx5/mlx5_ib.h

+1 −1
Original line number Diff line number Diff line
@@ -461,7 +461,7 @@ void __mlx5_ib_cq_clean(struct mlx5_ib_cq *cq, u32 qpn, struct mlx5_ib_srq *srq) 
void mlx5_ib_cq_clean(struct mlx5_ib_cq *cq, u32 qpn, struct mlx5_ib_srq *srq);

void mlx5_ib_free_srq_wqe(struct mlx5_ib_srq *srq, int wqe_index);

int mlx5_MAD_IFC(struct mlx5_ib_dev *dev, int ignore_mkey, int ignore_bkey,

		 int port, struct ib_wc *in_wc, struct ib_grh *in_grh,

		 u8 port, struct ib_wc *in_wc, struct ib_grh *in_grh,

		 void *in_mad, void *response_mad);

struct ib_ah *create_ib_ah(struct ib_ah_attr *ah_attr,

			   struct mlx5_ib_ah *ah);