Commit f22cf8eb authored Sep 05, 2012 by Dan Carpenter Committed by Rusty Russell Sep 28, 2012

virtio-blk: fix NULL checking in virtblk_alloc_req()



Smatch complains about the inconsistent NULL checking here.  Fix it to
return NULL on failure.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (fixed accidental deletion)

parent c85a1f91

drivers/block/virtio_blk.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -90,10 +90,12 @@ static inline struct virtblk_req virtblk_alloc_req(struct virtio_blk vblk,
		struct virtblk_req *vbr;

		vbr = mempool_alloc(vblk->pool, gfp_mask);
		if (vbr && use_bio)
		sg_init_table(vbr->sg, vblk->sg_elems);
		if (!vbr)
		return NULL;

		vbr->vblk = vblk;
		if (use_bio)
		sg_init_table(vbr->sg, vblk->sg_elems);

		return vbr;
		}