Unverified Commit f2126f6d authored Apr 09, 2018 by Jia-Ju Bai Committed by Mark Brown Apr 16, 2018

ASoC: intel: bxt_da7219_max98357a: Replace GFP_ATOMIC with GFP_KERNEL in broxton_audio_probe



broxton_audio_probe() is never called in atomic context.
This function is only set as ".probe" in "struct platform_driver".

Despite never getting called from atomic context,
broxton_audio_probe() calls devm_kzalloc() with GFP_ATOMIC,
which waits busily for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
to avoid busy waiting and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 0ae91ec4

sound/soc/intel/boards/bxt_da7219_max98357a.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -571,7 +571,7 @@ static int broxton_audio_probe(struct platform_device *pdev)
	{		{
	struct bxt_card_private *ctx;		struct bxt_card_private *ctx;

	ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_ATOMIC);		ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL);
	if (!ctx)		if (!ctx)
	return -ENOMEM;		return -ENOMEM;