Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1cf2dbd authored by Lukáš Turek's avatar Lukáš Turek Committed by John W. Linville
Browse files

ath5k: Fix I/Q calibration 



The sign of correction coefficients was lost in the calculations, which
caused high packetloss in 802.11a mode after the results were applied.
Fixed by removing unneccesary and broken AND with a bit mask.

Signed-off-by: default avatarLukas Turek <8an@praha12.net>
Acked-by: default avatarNick Kossifidis <mickflemm@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 98e3ac99

drivers/net/wireless/ath/ath5k/phy.c

+2 −2
Original line number Diff line number Diff line
@@ -1399,7 +1399,7 @@ static int ath5k_hw_rf511x_calibrate(struct ath5k_hw *ah, 
	if (i_coffd == 0 || q_coffd == 0)

		goto done;



	i_coff = ((-iq_corr) / i_coffd) & 0x3f;

	i_coff = ((-iq_corr) / i_coffd);



	/* Boundary check */

	if (i_coff > 31)
@@ -1407,7 +1407,7 @@ static int ath5k_hw_rf511x_calibrate(struct ath5k_hw *ah, 
	if (i_coff < -32)

		i_coff = -32;



	q_coff = (((s32)i_pwr / q_coffd) - 128) & 0x1f;

	q_coff = (((s32)i_pwr / q_coffd) - 128);



	/* Boundary check */

	if (q_coff > 15)