Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1bf9072 authored by Fabian Frederick's avatar Fabian Frederick Committed by Al Viro
Browse files

fs/affs: bugfix: make symbolic links work again 



AFFS symbolic links were broken since kernel 2.6.29

Problem was bisected to the following

commit ebd09abb ("vfs: ensure page symlinks are NUL-terminated")
commit 03514685 ("vfs: introduce helper function to safely
NUL-terminate symlinks")

AFFS wasn't setting inode size when reading symbolic link from disk or
creating a new one. Result was zero allocation in pagecache.

ln -s file symlink

ls -lrt

file
symlink ->

This patch adds inode isize information on inode get and symbolic link
addition.

Signed-off-by: default avatarFabian Frederick <fabf@skynet.be>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 4f7d029b

fs/affs/inode.c

+1 −0
Original line number Diff line number Diff line
@@ -140,6 +140,7 @@ struct inode *affs_iget(struct super_block *sb, unsigned long ino) 
		inode->i_fop = &affs_file_operations;

		break;

	case ST_SOFTLINK:

		inode->i_size = strlen((char *)AFFS_HEAD(bh)->table);

		inode->i_mode |= S_IFLNK;

		inode_nohighmem(inode);

		inode->i_op = &affs_symlink_inode_operations;

fs/affs/namei.c

+1 −0
Original line number Diff line number Diff line
@@ -365,6 +365,7 @@ affs_symlink(struct inode *dir, struct dentry *dentry, const char *symname) 
				symname++;

	}

	*p = 0;

	inode->i_size = i + 1;

	mark_buffer_dirty_inode(bh, inode);

	affs_brelse(bh);

	mark_inode_dirty(inode);