Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1917f21 authored by Stefan Wahren's avatar Stefan Wahren Committed by Greg Kroah-Hartman
Browse files

hwmon: (pwm-fan) Disable PWM if fetching cooling data fails 



commit 53f1647da3e8fb3e89066798f0fdc045064d353d upstream.

In case pwm_fan_of_get_cooling_data() fails we should disable the PWM
just like in the other error cases.

Fixes: 2e5219c7 ("hwmon: (pwm-fan) Read PWM FAN configuration from device tree")
Cc: <stable@vger.kernel.org> # 4.14+
Reported-by: default avatarGuenter Rock <linux@roeck-us.net>
Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 87cc345a

drivers/hwmon/pwm-fan.c

+1 −1
Original line number Diff line number Diff line
@@ -250,7 +250,7 @@ static int pwm_fan_probe(struct platform_device *pdev) 


	ret = pwm_fan_of_get_cooling_data(&pdev->dev, ctx);

	if (ret)

		return ret;

		goto err_pwm_disable;



	ctx->pwm_fan_state = ctx->pwm_fan_max_state;

	if (IS_ENABLED(CONFIG_THERMAL)) {