Commit f180e239 authored May 19, 2021 by Dan Carpenter Committed by Greg Kroah-Hartman Aug 11, 2023

w1: fix loop in w1_fini()



[ Upstream commit 83f3fcf96fcc7e5405b37d9424c7ef26bfa203f8 ]

The __w1_remove_master_device() function calls:

	list_del(&dev->w1_master_entry);

So presumably this can cause an endless loop.

Fixes: 7785925d ("[PATCH] w1: cleanups.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4c7dc739

drivers/w1/w1.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1237,10 +1237,10 @@ static int __init w1_init(void)

		static void __exit w1_fini(void)
		{
		struct w1_master *dev;
		struct w1_master dev, n;

		/* Set netlink removal messages and some cleanup */
		list_for_each_entry(dev, &w1_masters, w1_master_entry)
		list_for_each_entry_safe(dev, n, &w1_masters, w1_master_entry)
		__w1_remove_master_device(dev);

		w1_fini_netlink();