Commit f1474463 authored Jun 28, 2022 by Satish Nagireddy Committed by Greg Kroah-Hartman Jul 12, 2022

i2c: cadence: Unregister the clk notifier in error path



[ Upstream commit 3501f0c663063513ad604fb1b3f06af637d3396d ]

This patch ensures that the clock notifier is unregistered
when driver probe is returning error.

Fixes: df8eb569 ("i2c: Add driver for Cadence I2C controller")
Signed-off-by: Satish Nagireddy <satish.nagireddy@getcruise.com>
Tested-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Michal Simek <michal.simek@amd.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 70652a44

drivers/i2c/busses/i2c-cadence.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -990,6 +990,7 @@ static int cdns_i2c_probe(struct platform_device *pdev)
	return 0;		return 0;

	err_clk_dis:		err_clk_dis:
			clk_notifier_unregister(id->clk, &id->clk_rate_change_nb);
	clk_disable_unprepare(id->clk);		clk_disable_unprepare(id->clk);
	pm_runtime_set_suspended(&pdev->dev);		pm_runtime_set_suspended(&pdev->dev);
	pm_runtime_disable(&pdev->dev);		pm_runtime_disable(&pdev->dev);