Commit f118920b authored Feb 24, 2014 by Jean Delvare Committed by Borislav Petkov Feb 25, 2014

i7core_edac: Drop unused variable



Fix the following warning:

drivers/edac/i7core_edac.c: In function "core_mce_output_error":
drivers/edac/i7core_edac.c:1711:8: warning: variable "type" set but not used [-Wunused-but-set-variable]
  char *type, *optype, *err;
        ^
According to Mauro, type can just be dropped, as tp_event now maps if
the error is corrected, uncorrected non-fatal or uncorrected fatal
one.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Link: http://lkml.kernel.org/r/20140224171358.692d7e5a@endymion.delvare


Acked-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Doug Thompson <dougthompson@xmission.com>
Signed-off-by: Borislav Petkov <bp@suse.de>

parent 5fdae419

drivers/edac/i7core_edac.c

+3 −7

Original line number	Diff line number	Diff line
		@@ -1703,7 +1703,7 @@ static void i7core_mce_output_error(struct mem_ctl_info *mci,
		const struct mce *m)
		{
		struct i7core_pvt *pvt = mci->pvt_info;
		char type, optype, *err;
		char optype, err;
		enum hw_event_mc_err_type tp_event;
		unsigned long error = m->status & 0x1ff0000l;
		bool uncorrected_error = m->mcgstatus & 1ll << 61;
		@@ -1716,15 +1716,11 @@ static void i7core_mce_output_error(struct mem_ctl_info *mci,
		u32 errnum = find_first_bit(&error, 32);

		if (uncorrected_error) {
		if (ripv) {
		type = "FATAL";
		if (ripv)
		tp_event = HW_EVENT_ERR_FATAL;
		} else {
		type = "NON_FATAL";
		else
		tp_event = HW_EVENT_ERR_UNCORRECTED;
		}
		} else {
		type = "CORRECTED";
		tp_event = HW_EVENT_ERR_CORRECTED;
		}