Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f0b4198f authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

USB: serial: remove redundant initializations of 'mos_parport' 



The pointer mos_parport is being initialized to pp->private_data and
then the assignment is duplicated after a spin lock.  Remove the
initialization as it occurs before the spin lock and it is a redundant
assignment.

Cleans up clang warnings:
drivers/usb/serial/mos7720.c:521:26: warning: Value stored to
'mos_parport' during its initialization is never read
drivers/usb/serial/mos7720.c:557:26: warning: Value stored to
'mos_parport' during its initialization is never read

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 11fb3799

drivers/usb/serial/mos7720.c

+2 −2
Original line number Diff line number Diff line
@@ -518,7 +518,7 @@ static void parport_mos7715_write_control(struct parport *pp, unsigned char d) 


static unsigned char parport_mos7715_read_control(struct parport *pp)

{

	struct mos7715_parport *mos_parport = pp->private_data;

	struct mos7715_parport *mos_parport;

	__u8 dcr;



	spin_lock(&release_lock);
@@ -554,7 +554,7 @@ static unsigned char parport_mos7715_frob_control(struct parport *pp, 
static unsigned char parport_mos7715_read_status(struct parport *pp)

{

	unsigned char status;

	struct mos7715_parport *mos_parport = pp->private_data;

	struct mos7715_parport *mos_parport;



	spin_lock(&release_lock);

	mos_parport = pp->private_data;