Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f016d24a authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf hists browser: Rename perf_evsel_browser_title to a more descriptive name 

Rename it to hists_browser__scnprintf_title() to better reflect that it
provides a scnprintf-like function operating on a hists_browser
instance.

This paves the way to have a non-hists_browser specific function to
scnprintf format a title with per evsel information to use in other
tools or UIs.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Martin Liška <mliska@suse.cz>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196935
Link: https://lkml.kernel.org/n/tip-sntpyzxsnme9jvuz2qntwoh2@git.kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 70984672

tools/perf/ui/browsers/hists.c

+3 −5
Original line number Original line Diff line number Diff line
@@ -32,8 +32,7 @@ 




extern void hist_browser__init_hpp(void);

extern void hist_browser__init_hpp(void);





static int perf_evsel_browser_title(struct hist_browser *browser,

static int hists_browser__scnprintf_title(struct hist_browser *browser, char *bf, size_t size);

				    char *bf, size_t size);

static void hist_browser__update_nr_entries(struct hist_browser *hb);

static void hist_browser__update_nr_entries(struct hist_browser *hb);





static struct rb_node *hists__filter_entries(struct rb_node *nd,

static struct rb_node *hists__filter_entries(struct rb_node *nd,
@@ -2183,7 +2182,7 @@ perf_evsel_browser__new(struct perf_evsel *evsel, 
	if (browser) {

	if (browser) {

		browser->hbt   = hbt;

		browser->hbt   = hbt;

		browser->env   = env;

		browser->env   = env;

		browser->title = perf_evsel_browser_title;

		browser->title = hists_browser__scnprintf_title;

	}

	}

	return browser;

	return browser;

}

}
@@ -2209,8 +2208,7 @@ static inline bool is_report_browser(void *timer) 
	return timer == NULL;

	return timer == NULL;

}

}





static int perf_evsel_browser_title(struct hist_browser *browser,

static int hists_browser__scnprintf_title(struct hist_browser *browser, char *bf, size_t size)

				char *bf, size_t size)

{

{

	struct hist_browser_timer *hbt = browser->hbt;

	struct hist_browser_timer *hbt = browser->hbt;

	struct hists *hists = browser->hists;

	struct hists *hists = browser->hists;