Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eec0eacf authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

media: staging/imx: Missing assignment in imx_media_capture_device_register() 



[ Upstream commit ef0ed05dcef8a74178a8b480cce23a377b1de2b8 ]

There was supposed to be a "ret = " assignment here, otherwise the
error handling on the next line won't work.

Fixes: 64b5a49d ("[media] media: imx: Add Capture Device Interface")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarSteve Longerbeam <slongerbeam@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent bb198240

drivers/staging/media/imx/imx-media-capture.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -678,7 +678,7 @@ int imx_media_capture_device_register(struct imx_media_video_dev *vdev) 
	/* setup default format */

	/* setup default format */

	fmt_src.pad = priv->src_sd_pad;

	fmt_src.pad = priv->src_sd_pad;

	fmt_src.which = V4L2_SUBDEV_FORMAT_ACTIVE;

	fmt_src.which = V4L2_SUBDEV_FORMAT_ACTIVE;

	v4l2_subdev_call(sd, pad, get_fmt, NULL, &fmt_src);

	ret = v4l2_subdev_call(sd, pad, get_fmt, NULL, &fmt_src);

	if (ret) {

	if (ret) {

		v4l2_err(sd, "failed to get src_sd format\n");

		v4l2_err(sd, "failed to get src_sd format\n");

		goto unreg;

		goto unreg;