Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eeb770d6 authored by Xin Long's avatar Xin Long Committed by Greg Kroah-Hartman
Browse files

sctp: change to hold sk after auth shkey is created successfully 



[ Upstream commit 25bff6d5478b2a02368097015b7d8eb727c87e16 ]

Now in sctp_endpoint_init(), it holds the sk then creates auth
shkey. But when the creation fails, it doesn't release the sk,
which causes a sk defcnf leak,

Here to fix it by only holding the sk when auth shkey is created
successfully.

Fixes: a29a5bd4 ("[SCTP]: Implement SCTP-AUTH initializations.")
Reported-by: default avatar <syzbot+afabda3890cc2f765041@syzkaller.appspotmail.com>
Reported-by: default avatar <syzbot+276ca1c77a19977c0130@syzkaller.appspotmail.com>
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Acked-by: default avatarNeil Horman <nhorman@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9b7b0aab

net/sctp/endpointola.c

+4 −4
Original line number Diff line number Diff line
@@ -126,10 +126,6 @@ static struct sctp_endpoint *sctp_endpoint_init(struct sctp_endpoint *ep, 
	/* Initialize the bind addr area */

	sctp_bind_addr_init(&ep->base.bind_addr, 0);



	/* Remember who we are attached to.  */

	ep->base.sk = sk;

	sock_hold(ep->base.sk);



	/* Create the lists of associations.  */

	INIT_LIST_HEAD(&ep->asocs);
@@ -167,6 +163,10 @@ static struct sctp_endpoint *sctp_endpoint_init(struct sctp_endpoint *ep, 
	ep->prsctp_enable = net->sctp.prsctp_enable;

	ep->reconf_enable = net->sctp.reconf_enable;



	/* Remember who we are attached to.  */

	ep->base.sk = sk;

	sock_hold(ep->base.sk);



	return ep;



nomem_hmacs: