Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee404810 authored by Wen Yang's avatar Wen Yang Committed by Greg Kroah-Hartman
Browse files

drm/msm: Fix error return checking 



[ Upstream commit 098336deb946f37a70afc0979af388b615c378bf ]

The error checks on ret for a negative error return always fails because
the return value of iommu_map_sg() is unsigned and can never be negative.

Detected with Coccinelle:
drivers/gpu/drm/msm/msm_iommu.c:69:9-12: WARNING: Unsigned expression
compared with zero: ret < 0

Signed-off-by: default avatarWen Yang <wen.yang99@zte.com.cn>
CC: Rob Clark <robdclark@gmail.com>
CC: David Airlie <airlied@linux.ie>
CC: Julia Lawall <julia.lawall@lip6.fr>
CC: linux-arm-msm@vger.kernel.org
CC: dri-devel@lists.freedesktop.org
CC: freedreno@lists.freedesktop.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: default avatarSean Paul <seanpaul@chromium.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 38b579de

drivers/gpu/drm/msm/msm_iommu.c

+1 −1
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ static int msm_iommu_map(struct msm_mmu *mmu, uint64_t iova, 
//	pm_runtime_get_sync(mmu->dev);

	ret = iommu_map_sg(iommu->domain, iova, sgt->sgl, sgt->nents, prot);

//	pm_runtime_put_sync(mmu->dev);

	WARN_ON(ret < 0);

	WARN_ON(!ret);



	return (ret == len) ? 0 : -EINVAL;

}