Commit ee203be4 authored Aug 03, 2020 by Marcos Paulo de Souza Committed by Greg Kroah-Hartman Sep 03, 2020

btrfs: reset compression level for lzo on remount



commit 282dd7d7718444679b046b769d872b188818ca35 upstream.

Currently a user can set mount "-o compress" which will set the
compression algorithm to zlib, and use the default compress level for
zlib (3):

  relatime,compress=zlib:3,space_cache

If the user remounts the fs using "-o compress=lzo", then the old
compress_level is used:

  relatime,compress=lzo:3,space_cache

But lzo does not expose any tunable compression level. The same happens
if we set any compress argument with different level, also with zstd.

Fix this by resetting the compress_level when compress=lzo is
specified.  With the fix applied, lzo is shown without compress level:

  relatime,compress=lzo,space_cache

CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 77064570

fs/btrfs/super.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -539,6 +539,7 @@ int btrfs_parse_options(struct btrfs_fs_info info, char options,
		} else if (strncmp(args[0].from, "lzo", 3) == 0) {
		compress_type = "lzo";
		info->compress_type = BTRFS_COMPRESS_LZO;
		info->compress_level = 0;
		btrfs_set_opt(info->mount_opt, COMPRESS);
		btrfs_clear_opt(info->mount_opt, NODATACOW);
		btrfs_clear_opt(info->mount_opt, NODATASUM);