Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee07862f authored by Yafang Shao's avatar Yafang Shao Committed by Daniel Borkmann
Browse files

bpf: NULL pointer check is not needed in BPF_CGROUP_RUN_PROG_INET_SOCK 



sk is already allocated in inet_create/inet6_create, hence when
BPF_CGROUP_RUN_PROG_INET_SOCK is executed sk will never be NULL.

The logic is as bellow,
	sk = sk_alloc();
	if (!sk)
		goto out;
	BPF_CGROUP_RUN_PROG_INET_SOCK(sk);

Signed-off-by: default avatarYafang Shao <laoar.shao@gmail.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent 0b6b8a3d

include/linux/bpf-cgroup.h

+1 −1
Original line number Diff line number Diff line
@@ -96,7 +96,7 @@ int __cgroup_bpf_check_dev_permission(short dev_type, u32 major, u32 minor, 
#define BPF_CGROUP_RUN_PROG_INET_SOCK(sk)				       \

({									       \

	int __ret = 0;							       \

	if (cgroup_bpf_enabled && sk) {					       \

	if (cgroup_bpf_enabled) {					       \

		__ret = __cgroup_bpf_run_filter_sk(sk,			       \

						 BPF_CGROUP_INET_SOCK_CREATE); \

	}								       \