Commit ee021d42 authored Dec 10, 2013 by Arnaldo Carvalho de Melo

perf symbols: Set freed members to NULL in dso destructor



To help in debugging use after free bugs.

Reported-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-3ckwsob2g1q23s77nuhexrq7@git.kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent bf4414ae

tools/perf/util/dso.c

+12 −2

Original line number	Diff line number	Diff line
		@@ -475,13 +475,23 @@ void dso__delete(struct dso *dso)
		int i;
		for (i = 0; i < MAP__NR_TYPES; ++i)
		symbols__delete(&dso->symbols[i]);
		if (dso->short_name_allocated)

		if (dso->short_name_allocated) {
		free((char *)dso->short_name);
		if (dso->long_name_allocated)
		dso->short_name = NULL;
		dso->short_name_allocated = false;
		}

		if (dso->long_name_allocated) {
		free((char *)dso->long_name);
		dso->long_name = NULL;
		dso->long_name_allocated = false;
		}

		dso_cache__free(&dso->cache);
		dso__free_a2l(dso);
		free(dso->symsrc_filename);
		dso->symsrc_filename = NULL;
		free(dso);
		}