Commit edd40f54 authored Jun 10, 2019 by Tomi Valkeinen Committed by Greg Kroah-Hartman Sep 06, 2019

drm/bridge: tfp410: fix memleak in get_modes()



[ Upstream commit c08f99c39083ab55a9c93b3e93cef48711294dad ]

We don't free the edid blob allocated by the call to drm_get_edid(),
causing a memleak. Fix this by calling kfree(edid) at the end of the
get_modes().

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190610135739.6077-1-tomi.valkeinen@ti.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2fa7c944

drivers/gpu/drm/bridge/ti-tfp410.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -64,7 +64,12 @@ static int tfp410_get_modes(struct drm_connector *connector)

		drm_connector_update_edid_property(connector, edid);

		return drm_add_edid_modes(connector, edid);
		ret = drm_add_edid_modes(connector, edid);

		kfree(edid);

		return ret;

		fallback:
		/* No EDID, fallback on the XGA standard modes */
		ret = drm_add_modes_noedid(connector, 1920, 1200);