Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit edc11d49 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mike Snitzer
Browse files

dm bufio: fix error code in dm_bufio_write_dirty_buffers() 



We should be returning normal negative error codes here.  The "a"
variables comes from &c->async_write_error which is a blk_status_t
converted to a regular error code.

In the current code, the blk_status_t gets propogated back to
pool_create() and eventually results in an Oops.

Fixes: 4e4cbee9 ("block: switch bios to blk_status_t")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent bc86a41e

drivers/md/dm-bufio.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -1258,8 +1258,7 @@ EXPORT_SYMBOL_GPL(dm_bufio_write_dirty_buffers_async); 
 */

 */

int dm_bufio_write_dirty_buffers(struct dm_bufio_client *c)

int dm_bufio_write_dirty_buffers(struct dm_bufio_client *c)

{

{

	blk_status_t a;

	int a, f;

	int f;

	unsigned long buffers_processed = 0;

	unsigned long buffers_processed = 0;

	struct dm_buffer *b, *tmp;

	struct dm_buffer *b, *tmp;