Commit eda1827e authored Mar 08, 2021 by Arnaldo Carvalho de Melo Committed by Greg Kroah-Hartman May 22, 2021

perf symbols: Fix dso__fprintf_symbols_by_name() to return the number of printed chars



[ Upstream commit 210e4c89ef61432040c6cd828fefa441f4887186 ]

The 'ret' variable was initialized to zero but then it was not updated
from the fprintf() return, fix it.

Reported-by: Yang Li <yang.lee@linux.alibaba.com>
cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
cc: Ingo Molnar <mingo@redhat.com>
cc: Jiri Olsa <jolsa@redhat.com>
cc: Mark Rutland <mark.rutland@arm.com>
cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Fixes: 90f18e63 ("perf symbols: List symbols in a dso in ascending name order")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 878177b8

tools/perf/util/symbol_fprintf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -66,7 +66,7 @@ size_t dso__fprintf_symbols_by_name(struct dso *dso,

		for (nd = rb_first(&dso->symbol_names); nd; nd = rb_next(nd)) {
		pos = rb_entry(nd, struct symbol_name_rb_node, rb_node);
		fprintf(fp, "%s\n", pos->sym.name);
		ret += fprintf(fp, "%s\n", pos->sym.name);
		}

		return ret;