Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed77ed61 authored by Vasiliy Kulikov's avatar Vasiliy Kulikov Committed by Linus Torvalds
Browse files

drivers/char/synclink_gt.c: fix information leak to userland 



Structures tmp_params and new_line are copied to userland with some
padding fields unitialized.  It leads to leaking of stack memory.

Signed-off-by: default avatarVasiliy Kulikov <segooon@gmail.com>
Acked-by: default avatarPaul Fulghum <paulkf@microgate.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b9b11342

drivers/char/synclink_gt.c

+3 −0
Original line number Diff line number Diff line
@@ -1132,6 +1132,7 @@ static long get_params32(struct slgt_info *info, struct MGSL_PARAMS32 __user *us 
	struct MGSL_PARAMS32 tmp_params;



	DBGINFO(("%s get_params32\n", info->device_name));

	memset(&tmp_params, 0, sizeof(tmp_params));

	tmp_params.mode            = (compat_ulong_t)info->params.mode;

	tmp_params.loopback        = info->params.loopback;

	tmp_params.flags           = info->params.flags;
@@ -1617,6 +1618,8 @@ static int hdlcdev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) 
	if (cmd != SIOCWANDEV)

		return hdlc_ioctl(dev, ifr, cmd);



	memset(&new_line, 0, sizeof(new_line));



	switch(ifr->ifr_settings.type) {

	case IF_GET_IFACE: /* return current sync_serial_settings */