Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed505ee4 authored by Eric Sandeen's avatar Eric Sandeen Committed by Jan Kara
Browse files

ext3: Remove outdated comment about lock_super() 



ext3_fill_super() is no longer called by read_super(), and it is no
longer called with the superblock locked.  The
unlock_super()/lock_super() is no longer present, so this comment is
entirely superfluous.

Port of ext4 commit 32ed5058 by
Theodore Ts'o <tytso@mit.edu>.

CC: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent dc52dd3a

fs/ext3/super.c

+1 −8
Original line number Diff line number Diff line
@@ -2014,14 +2014,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) 
	}



	ext3_setup_super (sb, es, sb->s_flags & MS_RDONLY);

	/*

	 * akpm: core read_super() calls in here with the superblock locked.

	 * That deadlocks, because orphan cleanup needs to lock the superblock

	 * in numerous places.  Here we just pop the lock - it's relatively

	 * harmless, because we are now ready to accept write_super() requests,

	 * and aviro says that's the only reason for hanging onto the

	 * superblock lock.

	 */



	EXT3_SB(sb)->s_mount_state |= EXT3_ORPHAN_FS;

	ext3_orphan_cleanup(sb, es);

	EXT3_SB(sb)->s_mount_state &= ~EXT3_ORPHAN_FS;