Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ece550b5 authored by Bhumika Goyal's avatar Bhumika Goyal Committed by Christoph Hellwig
Browse files

target: make config_item_type const 



Make these structures const as they are either passed to the functions
having the argument as const or stored as a reference in the "ci_type"
const field of a config_item structure.

Done using Coccinelle.

Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent aa293583

drivers/target/iscsi/iscsi_target_stat.c

+6 −6
Original line number Original line Diff line number Diff line
@@ -187,7 +187,7 @@ static struct configfs_attribute *iscsi_stat_instance_attrs[] = { 
	NULL,

	NULL,

};

};





struct config_item_type iscsi_stat_instance_cit = {

const struct config_item_type iscsi_stat_instance_cit = {

	.ct_attrs		= iscsi_stat_instance_attrs,

	.ct_attrs		= iscsi_stat_instance_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};
@@ -249,7 +249,7 @@ static struct configfs_attribute *iscsi_stat_sess_err_attrs[] = { 
	NULL,

	NULL,

};

};





struct config_item_type iscsi_stat_sess_err_cit = {

const struct config_item_type iscsi_stat_sess_err_cit = {

	.ct_attrs		= iscsi_stat_sess_err_attrs,

	.ct_attrs		= iscsi_stat_sess_err_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};
@@ -390,7 +390,7 @@ static struct configfs_attribute *iscsi_stat_tgt_attr_attrs[] = { 
	NULL,

	NULL,

};

};





struct config_item_type iscsi_stat_tgt_attr_cit = {

const struct config_item_type iscsi_stat_tgt_attr_cit = {

	.ct_attrs		= iscsi_stat_tgt_attr_attrs,

	.ct_attrs		= iscsi_stat_tgt_attr_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};
@@ -522,7 +522,7 @@ static struct configfs_attribute *iscsi_stat_login_stats_attrs[] = { 
	NULL,

	NULL,

};

};





struct config_item_type iscsi_stat_login_cit = {

const struct config_item_type iscsi_stat_login_cit = {

	.ct_attrs		= iscsi_stat_login_stats_attrs,

	.ct_attrs		= iscsi_stat_login_stats_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};
@@ -579,7 +579,7 @@ static struct configfs_attribute *iscsi_stat_logout_stats_attrs[] = { 
	NULL,

	NULL,

};

};





struct config_item_type iscsi_stat_logout_cit = {

const struct config_item_type iscsi_stat_logout_cit = {

	.ct_attrs		= iscsi_stat_logout_stats_attrs,

	.ct_attrs		= iscsi_stat_logout_stats_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};
@@ -801,7 +801,7 @@ static struct configfs_attribute *iscsi_stat_sess_stats_attrs[] = { 
	NULL,

	NULL,

};

};





struct config_item_type iscsi_stat_sess_cit = {

const struct config_item_type iscsi_stat_sess_cit = {

	.ct_attrs		= iscsi_stat_sess_stats_attrs,

	.ct_attrs		= iscsi_stat_sess_stats_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};
 
};

drivers/target/target_core_configfs.c

+7 −7
Original line number Original line Diff line number Diff line
@@ -307,7 +307,7 @@ static struct configfs_attribute *target_core_fabric_item_attrs[] = { 
/*

/*

 * Provides Fabrics Groups and Item Attributes for /sys/kernel/config/target/

 * Provides Fabrics Groups and Item Attributes for /sys/kernel/config/target/

 */

 */

static struct config_item_type target_core_fabrics_item = {

static const struct config_item_type target_core_fabrics_item = {

	.ct_group_ops	= &target_core_fabric_group_ops,

	.ct_group_ops	= &target_core_fabric_group_ops,

	.ct_attrs	= target_core_fabric_item_attrs,

	.ct_attrs	= target_core_fabric_item_attrs,

	.ct_owner	= THIS_MODULE,

	.ct_owner	= THIS_MODULE,
@@ -2376,7 +2376,7 @@ static struct configfs_item_operations target_core_alua_lu_gp_ops = { 
	.release		= target_core_alua_lu_gp_release,

	.release		= target_core_alua_lu_gp_release,

};

};





static struct config_item_type target_core_alua_lu_gp_cit = {

static const struct config_item_type target_core_alua_lu_gp_cit = {

	.ct_item_ops		= &target_core_alua_lu_gp_ops,

	.ct_item_ops		= &target_core_alua_lu_gp_ops,

	.ct_attrs		= target_core_alua_lu_gp_attrs,

	.ct_attrs		= target_core_alua_lu_gp_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,
@@ -2434,7 +2434,7 @@ static struct configfs_group_operations target_core_alua_lu_gps_group_ops = { 
	.drop_item		= &target_core_alua_drop_lu_gp,

	.drop_item		= &target_core_alua_drop_lu_gp,

};

};





static struct config_item_type target_core_alua_lu_gps_cit = {

static const struct config_item_type target_core_alua_lu_gps_cit = {

	.ct_item_ops		= NULL,

	.ct_item_ops		= NULL,

	.ct_group_ops		= &target_core_alua_lu_gps_group_ops,

	.ct_group_ops		= &target_core_alua_lu_gps_group_ops,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,
@@ -2813,7 +2813,7 @@ static struct configfs_item_operations target_core_alua_tg_pt_gp_ops = { 
	.release		= target_core_alua_tg_pt_gp_release,

	.release		= target_core_alua_tg_pt_gp_release,

};

};





static struct config_item_type target_core_alua_tg_pt_gp_cit = {

static const struct config_item_type target_core_alua_tg_pt_gp_cit = {

	.ct_item_ops		= &target_core_alua_tg_pt_gp_ops,

	.ct_item_ops		= &target_core_alua_tg_pt_gp_ops,

	.ct_attrs		= target_core_alua_tg_pt_gp_attrs,

	.ct_attrs		= target_core_alua_tg_pt_gp_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,
@@ -2884,7 +2884,7 @@ TB_CIT_SETUP(dev_alua_tg_pt_gps, NULL, &target_core_alua_tg_pt_gps_group_ops, NU 
 * core/alua/lu_gps and core/alua/tg_pt_gps that are attached to

 * core/alua/lu_gps and core/alua/tg_pt_gps that are attached to

 * target_core_alua_cit in target_core_init_configfs() below.

 * target_core_alua_cit in target_core_init_configfs() below.

 */

 */

static struct config_item_type target_core_alua_cit = {

static const struct config_item_type target_core_alua_cit = {

	.ct_item_ops		= NULL,

	.ct_item_ops		= NULL,

	.ct_attrs		= NULL,

	.ct_attrs		= NULL,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,
@@ -3105,7 +3105,7 @@ static struct configfs_item_operations target_core_hba_item_ops = { 
	.release		= target_core_hba_release,

	.release		= target_core_hba_release,

};

};





static struct config_item_type target_core_hba_cit = {

static const struct config_item_type target_core_hba_cit = {

	.ct_item_ops		= &target_core_hba_item_ops,

	.ct_item_ops		= &target_core_hba_item_ops,

	.ct_group_ops		= &target_core_hba_group_ops,

	.ct_group_ops		= &target_core_hba_group_ops,

	.ct_attrs		= target_core_hba_attrs,

	.ct_attrs		= target_core_hba_attrs,
@@ -3188,7 +3188,7 @@ static struct configfs_group_operations target_core_group_ops = { 
	.drop_item	= target_core_call_delhbafromtarget,

	.drop_item	= target_core_call_delhbafromtarget,

};

};





static struct config_item_type target_core_cit = {

static const struct config_item_type target_core_cit = {

	.ct_item_ops	= NULL,

	.ct_item_ops	= NULL,

	.ct_group_ops	= &target_core_group_ops,

	.ct_group_ops	= &target_core_group_ops,

	.ct_attrs	= NULL,

	.ct_attrs	= NULL,

drivers/target/target_core_stat.c

+8 −8
Original line number Original line Diff line number Diff line
@@ -96,7 +96,7 @@ static struct configfs_attribute *target_stat_scsi_dev_attrs[] = { 
	NULL,

	NULL,

};

};





static struct config_item_type target_stat_scsi_dev_cit = {

static const struct config_item_type target_stat_scsi_dev_cit = {

	.ct_attrs		= target_stat_scsi_dev_attrs,

	.ct_attrs		= target_stat_scsi_dev_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};
@@ -193,7 +193,7 @@ static struct configfs_attribute *target_stat_scsi_tgt_dev_attrs[] = { 
	NULL,

	NULL,

};

};





static struct config_item_type target_stat_scsi_tgt_dev_cit = {

static const struct config_item_type target_stat_scsi_tgt_dev_cit = {

	.ct_attrs		= target_stat_scsi_tgt_dev_attrs,

	.ct_attrs		= target_stat_scsi_tgt_dev_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};
@@ -414,7 +414,7 @@ static struct configfs_attribute *target_stat_scsi_lu_attrs[] = { 
	NULL,

	NULL,

};

};





static struct config_item_type target_stat_scsi_lu_cit = {

static const struct config_item_type target_stat_scsi_lu_cit = {

	.ct_attrs		= target_stat_scsi_lu_attrs,

	.ct_attrs		= target_stat_scsi_lu_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};
@@ -540,7 +540,7 @@ static struct configfs_attribute *target_stat_scsi_port_attrs[] = { 
	NULL,

	NULL,

};

};





static struct config_item_type target_stat_scsi_port_cit = {

static const struct config_item_type target_stat_scsi_port_cit = {

	.ct_attrs		= target_stat_scsi_port_attrs,

	.ct_attrs		= target_stat_scsi_port_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};
@@ -724,7 +724,7 @@ static struct configfs_attribute *target_stat_scsi_tgt_port_attrs[] = { 
	NULL,

	NULL,

};

};





static struct config_item_type target_stat_scsi_tgt_port_cit = {

static const struct config_item_type target_stat_scsi_tgt_port_cit = {

	.ct_attrs		= target_stat_scsi_tgt_port_attrs,

	.ct_attrs		= target_stat_scsi_tgt_port_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};
@@ -844,7 +844,7 @@ static struct configfs_attribute *target_stat_scsi_transport_attrs[] = { 
	NULL,

	NULL,

};

};





static struct config_item_type target_stat_scsi_transport_cit = {

static const struct config_item_type target_stat_scsi_transport_cit = {

	.ct_attrs		= target_stat_scsi_transport_attrs,

	.ct_attrs		= target_stat_scsi_transport_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};
@@ -1206,7 +1206,7 @@ static struct configfs_attribute *target_stat_scsi_auth_intr_attrs[] = { 
	NULL,

	NULL,

};

};





static struct config_item_type target_stat_scsi_auth_intr_cit = {

static const struct config_item_type target_stat_scsi_auth_intr_cit = {

	.ct_attrs		= target_stat_scsi_auth_intr_attrs,

	.ct_attrs		= target_stat_scsi_auth_intr_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};
@@ -1378,7 +1378,7 @@ static struct configfs_attribute *target_stat_scsi_ath_intr_port_attrs[] = { 
	NULL,

	NULL,

};

};





static struct config_item_type target_stat_scsi_att_intr_port_cit = {

static const struct config_item_type target_stat_scsi_att_intr_port_cit = {

	.ct_attrs		= target_stat_scsi_ath_intr_port_attrs,

	.ct_attrs		= target_stat_scsi_ath_intr_port_attrs,

	.ct_owner		= THIS_MODULE,

	.ct_owner		= THIS_MODULE,

};

};

include/target/iscsi/iscsi_target_stat.h

+6 −6
Original line number Original line Diff line number Diff line
@@ -8,16 +8,16 @@ 
/*

/*

 * For struct iscsi_tiqn->tiqn_wwn default groups

 * For struct iscsi_tiqn->tiqn_wwn default groups

 */

 */

extern struct config_item_type iscsi_stat_instance_cit;

extern const struct config_item_type iscsi_stat_instance_cit;

extern struct config_item_type iscsi_stat_sess_err_cit;

extern const struct config_item_type iscsi_stat_sess_err_cit;

extern struct config_item_type iscsi_stat_tgt_attr_cit;

extern const struct config_item_type iscsi_stat_tgt_attr_cit;

extern struct config_item_type iscsi_stat_login_cit;

extern const struct config_item_type iscsi_stat_login_cit;

extern struct config_item_type iscsi_stat_logout_cit;

extern const struct config_item_type iscsi_stat_logout_cit;





/*

/*

 * For struct iscsi_session->se_sess default groups

 * For struct iscsi_session->se_sess default groups

 */

 */

extern struct config_item_type iscsi_stat_sess_cit;

extern const struct config_item_type iscsi_stat_sess_cit;





/* iSCSI session error types */

/* iSCSI session error types */

#define ISCSI_SESS_ERR_UNKNOWN		0

#define ISCSI_SESS_ERR_UNKNOWN		0