Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ecc3f3ed authored by Nicholas Mc Guire's avatar Nicholas Mc Guire Committed by Nicholas Bellinger
Browse files

ib_srpt: wait_for_completion_timeout does not return negative status 



This patch changes srpt_close_session() to properly use an unsigned long
for wait_for_completion_timeout()'s return value, and to update WARN_ON()
to only trigger for a zero return.

Signed-off-by: default avatarNicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 5cdf5a87

drivers/infiniband/ulp/srpt/ib_srpt.c

+2 −2
Original line number Diff line number Diff line
@@ -3518,7 +3518,7 @@ static void srpt_close_session(struct se_session *se_sess) 
	DECLARE_COMPLETION_ONSTACK(release_done);

	struct srpt_rdma_ch *ch;

	struct srpt_device *sdev;

	int res;

	unsigned long res;



	ch = se_sess->fabric_sess_ptr;

	WARN_ON(ch->sess != se_sess);
@@ -3533,7 +3533,7 @@ static void srpt_close_session(struct se_session *se_sess) 
	spin_unlock_irq(&sdev->spinlock);



	res = wait_for_completion_timeout(&release_done, 60 * HZ);

	WARN_ON(res <= 0);

	WARN_ON(res == 0);

}



/**