Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eca29da9 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

regulator: max77686: Consistently index opmode array by rdev id 



Mixed indexes were used for array of opmodes in max77686_data structure:
id of regulator and index of regulator_desc array.

These indexes are exactly the same but the mixture may confuse. Use
consistently the id of regulator.

Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 78ce6128

drivers/regulator/max77686.c

+4 −2
Original line number Diff line number Diff line
@@ -82,6 +82,7 @@ enum max77686_ramp_rate { 
};



struct max77686_data {

	/* Array indexed by regulator id */

	unsigned int opmode[MAX77686_REGULATORS];

};
@@ -513,12 +514,13 @@ static int max77686_pmic_probe(struct platform_device *pdev) 


	for (i = 0; i < MAX77686_REGULATORS; i++) {

		struct regulator_dev *rdev;

		int id = regulators[i].id;



		config.init_data = pdata->regulators[i].initdata;

		config.of_node = pdata->regulators[i].of_node;



		max77686->opmode[i] = regulators[i].enable_mask >>

						max77686_get_opmode_shift(i);

		max77686->opmode[id] = regulators[i].enable_mask >>

						max77686_get_opmode_shift(id);

		rdev = devm_regulator_register(&pdev->dev,

						&regulators[i], &config);

		if (IS_ERR(rdev)) {