Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ec913f31 authored by Heinrich Schuchardt's avatar Heinrich Schuchardt Committed by Daniel Vetter
Browse files

drm: avoid exposing kernel stack in compat_drm_getstats 



The C standard does not specify the size of the integer used
to store an enum. Hence in structure drm_stats32_t alignment
bytes may exist.

To avoid exposing bytes from the kernel stack it is
necessary to initialize variable s32 completely.

Signed-off-by: default avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1471802179-2886-1-git-send-email-xypron.glpk@gmx.de
parent f5bef0b8

drivers/gpu/drm/drm_ioc32.c

+1 −0
Original line number Diff line number Diff line
@@ -346,6 +346,7 @@ static int compat_drm_getstats(struct file *file, unsigned int cmd, 
	struct drm_stats __user *stats;

	int i, err;



	memset(&s32, 0, sizeof(drm_stats32_t));

	stats = compat_alloc_user_space(sizeof(*stats));

	if (!stats)

		return -EFAULT;