Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb85c50c authored by Sudeep Holla's avatar Sudeep Holla Committed by Rafael J. Wysocki
Browse files

cpufreq: scpi: fix static checker warning cdev isn't an ERR_PTR 



Commit 343a8d17 (cpufreq: scpi: remove arm_big_little dependency)
leads to the following static checker warning:

	drivers/cpufreq/scpi-cpufreq.c:203 scpi_cpufreq_ready()
	warn: 'cdev' isn't an ERR_PTR

of_cpufreq_cooling_register() returns NULL on error. This patch removes
the incorrect IS_ERR check on the returned pointer.

Fixes: 343a8d17 (cpufreq: scpi: remove arm_big_little dependency)
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 3d706716

drivers/cpufreq/scpi-cpufreq.c

+1 −4
Original line number Diff line number Diff line
@@ -197,11 +197,8 @@ static int scpi_cpufreq_exit(struct cpufreq_policy *policy) 
static void scpi_cpufreq_ready(struct cpufreq_policy *policy)

{

	struct scpi_data *priv = policy->driver_data;

	struct thermal_cooling_device *cdev;



	cdev = of_cpufreq_cooling_register(policy);

	if (!IS_ERR(cdev))

		priv->cdev = cdev;

	priv->cdev = of_cpufreq_cooling_register(policy);

}



static struct cpufreq_driver scpi_cpufreq_driver = {