Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb70ac1b authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

[media] wl128x: fix compiler warning + wrong write() return 



The fix is to check for ret and return -EFAULT if non-zero.

I also noticed that write() didn't return the number of bytes written.
Fixed as well.

Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent f68afe5d

drivers/media/radio/wl128x/fmdrv_v4l2.c

+3 −1
Original line number Diff line number Diff line
@@ -84,12 +84,14 @@ static ssize_t fm_v4l2_fops_write(struct file *file, const char __user * buf, 
	ret = copy_from_user(&rds, buf, sizeof(rds));

	fmdbg("(%d)type: %d, text %s, af %d\n",

		   ret, rds.text_type, rds.text, rds.af_freq);

	if (ret)

		return -EFAULT;



	fmdev = video_drvdata(file);

	fm_tx_set_radio_text(fmdev, rds.text, rds.text_type);

	fm_tx_set_af(fmdev, rds.af_freq);



	return 0;

	return sizeof(rds);

}



static u32 fm_v4l2_fops_poll(struct file *file, struct poll_table_struct *pts)